[Freeciv-Dev] Re: Patch: disable turn done button until game really starts (PR#307)

[Mika Korhonen <mikak@xxxxxxxxxxxx>]

On Thu, 16 Mar 2000, Jeff Mallatt wrote:

>At 2000/03/16 02:05 , Mika Korhonen wrote:
>>
>>In gtk client the Turn done button appears clickable even if game has not
>>yet been started. This single-row :-) patch disables the button initially.
>>
>
>Thanks.  I hadn't noticed this, before.
>
>Now that I looked at it, I noticed that your patch misses on (hopefully
>rare) case: when the server disconnects from the client in the middle of a
>game.  When the client reconnects, the Turn Done button will be enabled
>even before the game is restarted.

You're right. I just reasoned that half asleep after work without bothering
to think whether there is another case where the dialog gets created and
the button should be enabled.

>
>How about moving your one line into gui_server_connect() in connectdlg.c?
>
>Attached is a patch which does this, and implements the same fix in the Xaw
>client.
>

That's the way you do it. Thanks.

        Mika