Complete.Org: Mailing Lists: Archives: freeciv-dev: March 2000:
[Freeciv-Dev] Re: Patch: disable turn done button until game really sta
Home

[Freeciv-Dev] Re: Patch: disable turn done button until game really sta

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Patch: disable turn done button until game really starts (PR#307)
From: Jeff Mallatt <jjm@xxxxxxxxxxxx>
Date: Thu, 16 Mar 2000 16:24:44 -0500

At 2000/03/16 02:05 , Mika Korhonen wrote:
>
>In gtk client the Turn done button appears clickable even if game has not
>yet been started. This single-row :-) patch disables the button initially.
>

Thanks.  I hadn't noticed this, before.

Now that I looked at it, I noticed that your patch misses on (hopefully
rare) case: when the server disconnects from the client in the middle of a
game.  When the client reconnects, the Turn Done button will be enabled
even before the game is restarted.

How about moving your one line into gui_server_connect() in connectdlg.c?

Attached is a patch which does this, and implements the same fix in the Xaw
client.

Attachment: turn_done-3.diff
Description: Text document

jjm

[Prev in Thread] Current Thread [Next in Thread]