Complete.Org: Mailing Lists: Archives: freeciv-dev: March 2000:
[Freeciv-Dev] Re: Add fortify and sentry field to gtk city menu
Home

[Freeciv-Dev] Re: Add fortify and sentry field to gtk city menu

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Add fortify and sentry field to gtk city menu
From: Jeff Mallatt <jjm@xxxxxxxxxxxx>
Date: Mon, 13 Mar 2000 15:43:57 -0500

At 2000/02/27 15:29 , Thue Janus Kristensen wrote:
>Clicking a unit in the gtk client now has these two exstra fields.

Here's a patch that implements the same thing in the Xaw client.  I moved
the routines that request the activity change to control.[hc], to conform
with other usage and so that the Xaw client could use the same code.

>It is the same patch I sendt earlier, except that I also modified the
>can_unit_do_activity_targeted function to allow units to change from non-idle
>activity to non-idle activity. (allows you to fx fortify a sentried unit).
> To check I didn't break anything I added calls to inform me when this
>behaviour was being used, and let 14 AI's play a game. Not used at all. It is
>used one place in the gtk-client, but that was redundant (you never use the
>menu of a sentried unit; it can't have focus). I briefly tested that I didn't
>break anything in the xaw client.

Hum...  I just noticed that Vasco checked-in the old version of this patch
(the one without the change to can_unit_do_activity_targeted()).  Was there
a reason to not change can_unit_do_activity_targeted()?

I've also attached a patch with just this part of Thue's larger patch.

Attachment: xaw-popup-options-0.diff
Description: Text document

Attachment: idle-not-required-0.diff
Description: Text document

jjm

[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] Re: Add fortify and sentry field to gtk city menu, Jeff Mallatt <=