[Freeciv-Dev] Re: freeciv 1.10 (PR#270)

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

On Tue, 22 Feb 2000, jf <jean-francois.bonnet@xxxxxxxxxxxxxxxxxxxxxxxx>
wrote:

> I just have noticed a bug (unless it is a new feature ?)
> in the city report, when I use the "change" button and select 
> more than 2 cities and wanna change the construction to the same 
> unit build for all of these cities, only the first selected cities 
> change its goal.

Yep, here is the fix (already checked into cvs).

-- David

--- freeciv-cvs/client/gui-gtk/cityrep.c        Mon Feb 21 23:13:29 2000
+++ freeciv-mod/client/gui-gtk/cityrep.c        Sat Mar 11 23:41:45 2000
@@ -317,13 +317,13 @@
 
       g_assert(selection);
   
+      if (is_unit)
+       number -= B_LAST;
+         
       for(; selection; selection = g_list_next(selection))
        {
          struct packet_city_request packet;
 
-         if (is_unit)
-           number -= B_LAST;
-         
          packet.city_id=city_from_glist(selection)->id;
          packet.name[0]='\0';
          packet.worklist.name[0] = '\0';