[Freeciv-Dev] Violation of the dumb-client principle

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxxxx>]

Hello freecivers

Using the city description patch (see last email) it is possible to see the
information of foreign cities. This is IMHO bad. Using a modified client it
is possible to get an advantage. 

I'm not sure if the following is a solution and the correct one.
In server/cityhand:send_city_info: blank all city fields except some general 
like position, name, owner, ... if dosend>=0 OR dest==NULL. I'm not sure
about this and there is also a comment:
  /* I'm declaring dosend < 0 to be a flag value to send the
  investigate packet.  If this offends anyone, feel free to
  rewrite send_city_info as a wrapper or something -- Syela */
So please comment.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "We've all heard that a million monkeys banging on a million typewriters
  will eventually reproduce the entire works of Shakespeare.
  Now, thanks to the Internet, we know this is not true."