[Freeciv-Dev] gtk-client Player-dialog spacehip-button (PR#262)

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

In the Gtk+ client, the "Spaceship" button in the Players dialog
doesn't work unless you have an embassy with that player.  In the
Xaw client you don't need an embassy.

I suggest that the Xaw client is correct, and that the attached 
patch be used to fix the Gtk+ client, on the following grounds:

- I think this matches Civ1 (don't know about Civ2; actually, to
match Civ1 more closely should probably get messages for each
spaceship part build by opponents);

- Presumably the spaceships are built in orbit, and it would be
hard to hide the large-scale details of such a construction from
another player with reasonably high tech;

- Like wonders, we could say that the construction of interstellar
spaceships are big enough news to be known all over the world;

- I suspect the gtk-client behaviour is a cut-and-paste error 
in players_sship_callback compared to players_intel_callback :-)

Regards,
-- David

--- freeciv-cvs/client/gui-gtk/plrdlg.c Sun Jan  2 22:51:57 2000
+++ freeciv-mod/client/gui-gtk/plrdlg.c Fri Feb 18 19:16:20 2000
@@ -315,6 +315,5 @@
   row=(gint)selection->data;
   player_index = list_index_to_player_index[row];
 
-  if(player_has_embassy(game.player_ptr, &game.players[player_index]))
-    popup_spaceship_dialog(&game.players[player_index]);
+  popup_spaceship_dialog(&game.players[player_index]);
 }