[Freeciv-Dev] Re: Nation names

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Robert Brady wrote:

> Here is a patch to implement per-nation government names, so instead of
> "Democracy of the Americans", you will get "United States of America",
> and instead of the "Communism of the Chinese", you will get "People's
> Republic of China."
> 
> I'm not sure if this is desirable or not, but here it is anyway...

Interesting.  I'm also a bit unsure just how desirable this is,
but here are some comments on the implementation.

- I'm a bit uncomfortable about having printf format strings
in user-editable ruleset files (and in packets), in that it 
provides a possible way for bad things to happen.  Though on
the other hand it does give considerable flexibility and avoid
the default being a "special case" rule...

- You are adding data to packets, so should worry about compatability
and capability strings (see common/capstr.c).  In this case should
be fairly easy: server detecting old client just leaves out data,
and client detecting old server uses old default string instead
of looking in packet.

- In government.c, include for config.h should be at top of file,
surrounded by #ifdef HAVE_CONFIG_H, as in other files.

- In nations.ruleset this doesn't look right ("Despotism"?)

@@ -478,6 +483,7 @@
 flag_alt = "f.united_kingdom"
 city_style = "European"
 ruler_titles = { "government",      "male_title",      "female_title"
+                 "Democracy",       _("King"),           _("King")
                  "Democracy",       _("Prime Minister"), _("Prime Minister")

Regards,
-- David