[Freeciv-Dev] Re: Nation names

[Robert Brady <rwb197@xxxxxxxxxxxxxxx>]

On Wed, 26 Jan 2000, David Pfitzner wrote:

> - I'm a bit uncomfortable about having printf format strings
> in user-editable ruleset files (and in packets), in that it 
> provides a possible way for bad things to happen.  Though on
> the other hand it does give considerable flexibility and avoid
> the default being a "special case" rule...

This is true. I shall revise this by sending a different format string and
not passing it to printf, but to something else. Additionally this will
solve the ordering problem I noticed.

> - You are adding data to packets, so should worry about compatability
> and capability strings (see common/capstr.c).  In this case should
> be fairly easy: server detecting old client just leaves out data,
> and client detecting old server uses old default string instead
> of looking in packet.

Right.

> - In government.c, include for config.h should be at top of file,
> surrounded by #ifdef HAVE_CONFIG_H, as in other files.

Ok.

> - In nations.ruleset this doesn't look right ("Despotism"?)
> 
> @@ -478,6 +483,7 @@
>  flag_alt = "f.united_kingdom"
>  city_style = "European"
>  ruler_titles = { "government",      "male_title",      "female_title"
> +                 "Democracy",       _("King"),           _("King")
>                   "Democracy",       _("Prime Minister"), _("Prime Minister")

Ugh. Yes. This was an error. Oops.

-- 
Robert
"Any person who knowingly causes a nuclear weapon test explosion or any other 
nuclear explosion is guilty of an offence and liable on conviction on 
indictment to imprisonment for life." -- Nuclear Explosions Act 1998.