[Freeciv-Dev] Re: Free food for cities on mountains

[Jeff Mallatt <jjm@xxxxxxxxxxxx>]

At 2000/01/03 12:49 , Tony Stuckey wrote:
>On Mon, Jan 03, 2000 at 06:34:38PM +0200, Marko Lindqvist wrote:
>>  I may have missed some discussion before or after this was implementet
>> (Sat Nov 6), but should't following lines from
>> common/city.c:get_tile_food() be a bit more general.
>> 
>> if (civstyle==2 && tile_t==T_MOUNTAINS && x==2 && y==2)
>>   f++;
>> 
>>  It seems to me that this tries to always give at least one food at
>> city center.
>
>       Exactly.
>
>> I don't know civ2 too well, so my point is not valid if:
>> 
>>  - (Irrigated) Mountains always give food.
>
>       They don't.
>
>>    or
>>  - Some other kind of (irrigated) terrain does not give any food even if
>>    city center.
>
>       Glacier would be the only other candidate -- every other tile gives
>food normally.
>
>>    (If either of these is true, possible food bonuses for city center
>>     should be controlled by terrain.ruleset)
>
>       Not really -- all city centers should produce at least one food.
>
>>  I suggest that it's changed into following form:
>> 
>> if (civstyle==2 && ! f && x==2 && y==2)
>>   f++;
>
>       That's probably better.

Sure.  I agree that this is probably a better general rule.

>
>>  Also, should this extra food really be affected by celebration and
>> pollution?
>
>       I wouldn't think so.  It's a gift. :)

Hum.  Maybe move it after celebration, but it should go before the government 
and pollution penalties.

jjm