[Freeciv-Dev] Free food for cities on mountains

[Marko Lindqvist <caz@xxxxxxxxxxxxxxxx>]

 I may have missed some discussion before or after this was implementet
(Sat Nov 6), but should't following lines from
common/city.c:get_tile_food() be a bit more general.

if (civstyle==2 && tile_t==T_MOUNTAINS && x==2 && y==2)
  f++;


 It seems to me that this tries to always give at least one food at
city center. I don't know civ2 too well, so my point is not valid if:

 - (Irrigated) Mountains always give food.
   or
 - Some other kind of (irrigated) terrain does not give any food even if
   city center.

   (If either of these is true, possible food bonuses for city center
    should be controlled by terrain.ruleset)


 I suggest that it's changed into following form:

if (civstyle==2 && ! f && x==2 && y==2)
  f++;


 Also, should this extra food really be affected by celebration and
pollution?

 
 Caz

--