[Freeciv-Dev] Re: (part of) Debian Bug #48024

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Lalo Martins <lalo@xxxxxxxxxx> wrote:

> Subject: Bug#48024: freeciv-gtk: mysterious errors and core
> Package: freeciv-gtk
> Version: 1.8.1+cvs19991010

> Sometimes, especially when buing things, the server gets
> 
> Game saved as civgame-500.sav
> > 
> 1: received bad string in packet (type 18, len 53) from bratek

I noticed this once in a game recently.  In particular I found
it occurs when doing "Change All" from City Report.

(In some ways its a good message: it means the server is defending
itself against buggy packets sent by the client...)

It seems to me the problem is in climisc.c:client_change_all(),
which neglects to initialize packet.name.  It should do somewhere:
    packet.name[0] = '\0';

(Or other possible changes, eg, send_packet_city_request() could
ignore/fill-in packet.name depending on the request type, but the 
above is simple and consistent with similar handling elsewhere in 
code regarding send_packet_city_request().)

-- David