Re: [Freeciv-Dev] Pollution with new techs

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Artur Biesiadowski wrote:

> Pollution modifier can be computed wrong in advdomestic.c:pollution_cost
> and in cityturn.c:set_pollution. I think it should be
>   mod = max(mod,i)
> instead of
>   mod = i
> (in other case order of techs in ruleset is important).

This has changed recently, and will change again soon; 
precisely which version are you referring to? 
In any case I don't see how your change would help, since 
always (mod <= i).  Perhaps you mean it should be mod++.

The current code is backward compatible to how freeciv has
done this for a long time; its unclear to me whether this
old behaviour was intentional or accidental.  The pollution
result depends on the order in which techs are specified in 
the techs.ruleset vector a_special.population_pollution, but 
not on the global tech order.

But this will probably change to your preference soon anyway,
because its easier to do when change to tech flags; see:

http://www.complete.org/mailinglists/archives/freeciv-dev-199908/msg00446.html
http://www.complete.org/mailinglists/archives/freeciv-dev-199908/msg00462.html
http://www.complete.org/mailinglists/archives/freeciv-dev-199909/msg00114.html


-- David