Complete.Org: Mailing Lists: Archives: freeciv-dev: August 1999:
[Freeciv-Dev] ARGH my_XawScrollbarSetThumb still broken
Home

[Freeciv-Dev] ARGH my_XawScrollbarSetThumb still broken

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] ARGH my_XawScrollbarSetThumb still broken
From: Falk Hueffner <falk.hueffner@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: 26 Aug 1999 18:15:21 +0200

Hi,

once again I debugged freeciv for quite some time to find the bug is
in my_XawScrollbarSetThumb. Could PLEASE somebody apply this patch?
Obviously, the current implementation is completely bogus, and as long 
as we don't know what he was trying to work around, I guess we don't
have much chance to fix it.

        Falk


--- mapview.c~  Tue Aug 24 18:39:34 1999
+++ mapview.c   Thu Aug 26 18:10:16 1999
@@ -1532,20 +1532,9 @@
 /**************************************************************************
 couldn't get the usual XawScrollbarSetThumb to work. tried everything.
 someone please tell me why - pu
+Well, I can't get his implementation to work; so I reverted it - ffh
 **************************************************************************/
 void my_XawScrollbarSetThumb(Widget w, float top, float shown)
 {
-  Arg arglist[2];
-
-  if(sizeof(float)>sizeof(XtArgVal)) {
-    XtSetArg(arglist[0], XtCTopOfThumb, &top);
-    XtSetArg(arglist[1], XtNshown, &shown);
-   }
-  else {
-    XtArgVal *l_top=(XtArgVal*)&top;
-    XtArgVal *l_shown=(XtArgVal*)&shown; 
-    XtSetArg(arglist[0], XtNtopOfThumb, *l_top);
-    XtSetArg(arglist[1], XtNshown, *l_shown);
-   }
-  XtSetValues(w, arglist, 2);
+  XawScrollbarSetThumb(w, top, shown);
 }

[Prev in Thread] Current Thread [Next in Thread]