Re: [Freeciv-Dev] MFC/GTK client

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Andy Black <ablack@xxxxxxxxxxxxxx> wrote:

> in set_turn_done_button_state in gui-gtk/mapctrl.c
> I think the the call
> gtk_widget_set_sensitive(turn_done_button, FALSE);
> should be
> gtk_widget_set_sensitive(turn_done_button, state);

Agreed and done; it seems it wasn't causing any problems
because this is only ever called with state==FALSE...

> Also, I think that sub routine should be moved to gui_stuff.c or
> gui_main.c. (probably gui_main.c becuase of gui_main_g.h)

Yeah.  Its currently pretty strange, with:

gui_main_g.h:void enable_turn_done_button(void);
mapctrl_g.h:void set_turn_done_button_state( int state );
mapview_g.h:void update_turn_done_button(int do_restore);

(And nary a comment on what the other ones do...)

-- David