Complete.Org: Mailing Lists: Archives: freeciv-dev: July 1999:
Re: [Freeciv-Dev] #include <x11/*> 		Home

Re: [Freeciv-Dev] #include <x11/*>

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: ablack@xxxxxxxxxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx
Subject: Re: [Freeciv-Dev] #include <x11/*>
From: David Pfitzner <dwp@xxxxxxxxxxxxxx>
Date: Fri, 16 Jul 1999 11:53:43 +1000 (EST) 
Andy Black wrote:

> If anyone adds a #include for an x-windows library to the common code
> (/server, /common, /ai, /client, /client/include) please considar if it is
> needed.

No, don't consider.  Code in those directories should not 
include X11 headers -- period.

>  The file I noticed the problem in is
> client/include/mapctrl_g.h. 

Thanks, thats a silly bug and I'll fix it ASAP.

> #if !(defined(GENERATING68K) || defined(GENERATINGPPC)) /* x-windows */
> #include <X11/Intrinsic.h>
> #endif /* end x-windows */

No, please do not do this.

-- David
[Prev in Thread] Current Thread [Next in Thread]