[Freeciv-Dev] Missing prototypes/#includes

[Andy Black <ablack@xxxxxxxxxxxxxx>]

Hi.
The folowing is an incomplete list of missing prototypes of files that are
mising the #include for it's header

Andy Black

The folowing is a list of funtions in the server setion of the 1.8.0
stable version
that do not have prototypes prototypes
in autoattack.c (needs #include "autoattack.h", place in autoattack.h)
        search_best_target
        auto_attack_with_unit
        auto_attack_city
        auto_attack_player
in citytools.c  (place in citytools.h)
        find_city_wonder
        split_player
in diplhand.c   (place in diplhand.h)
        find_treaty
in gamehand.c   (place in gamehand.h)
        calc_unit_ordering
        apply_unit_ordering
in gotohand.c   (place in gotohand.h)
        int_warmap
        dir_ok
        could_be_my_zoc
        goto_tile_cost
        init_gotomap
        dir_ect
        find_the_shortest_path
        find_a_directions
handchat.c      (needs #include "handchat.c")
mapgen.c        (needs #include "mapgen.h", place in mapgen.h)
        full_map
        make_mountains
        make_polar
        make_desert
        make_forest
        make_forests
        make_swamps
        make_desert
        make_river
        make_rivers
        make_plains
        make_passable
        make_fair
        make_land
        tiny_island
        filter_land
        flood_fill
        print_map
        print_hmap
        print_imap
        is_cold
plrhand.c       (place in plrhand.h)
        secompare
        historian_richest
        historian_advanced
        historian_military
        historian_happiest
        historian_largest
        nr_wonders
        rank_calc_research
        rank_research
        rank_calc_literacy
        rank_literacy
        rank_production
        rank_economics
        rank_pollution
        rank_calc_mil_service
        rank_mil_service
        number_to_string
        log_civ_score
        great_library
        update_revolution
settlers.c      (place in settlers.h)
        ai_do_build_city
        old_is_alread_assigned
        is_wet
        road_bonus
        assign_settlers_player
        assign_settlers
        assign_region
        assign_territory_player
        assign_teritory
stdinhand.c     (place in stdinhand.h)
        sset_is_changeable
        sset_is_to_client
        test_player_name
        meta_command
        name_of_skill_level
        handicap_of_skill_level
        fuzzy_of_skill_level
        expansionism_of_skill_level
        save_command
        toggle_ai_player
        create_ai_player
        remove_player
        lookup_cmd
        explain_option
        crash_and_burn
        show_command
        set_command
unithand.c      (place in unithand.h)
        wakeup_neighbor_sentries

The folowing is a list of funtions in the common setion of the 1.8.0
stable version
that do not have prototypes prototypes
player.c        (place in player.h)
        player_owns_active_wonder
        player_knows_improvement_tech
tech.c  (place in tech.h)
        tech_goals_turns_rec
        get_next_tech_rec
unit.c  (place in unit.h)
        is_heli_unittype

The folowing is a list of funtions in the AI setion of the 1.8.0 stable
version
that do not have prototypes prototypes
advattitude.c   (needs #include "advattitude.h")
advdomestic.c   (needs #include "advdomestic.h", place in advdomestic.h)
        ai_best_tile_value
        building_value
        ocean_workers
        railroad_trade
        farmland_food
        pollution_cost
advforeign.c    (needs #include "advforeign.h")
advisland.c     (needs #include "advisland.h")
advleader.c     (needs #include "advleader.h")
advmilitary.c   (needs #include "advmilitary.h", place in advdmilitary.h)
        assess_defense_backend
        assess_defense_igwall
        dangerfunct
        assess_danger_unit
        assess_distance
        process_defender_want
        process_attacker_want
        kill_something_with
        port_is_within
advscience.c    (needs #include "advscience.h")
advtrade.c      (needs #include "advtrade.c")
aicity.c        (place in aicity.h)
        ai_do_build_unit
        ai_city_build_defense
        ai_do_build_unit
        ai_city_build_peaceful_unit
        ai_manage_buildings
        ai_city_choose_build
        ai_city_defender_value
        try_to_sell_stuff
        ai_new_spend_gold
        worst_elvis_tile
        is_defender_unit
        ai_choose_attacker
        adjust_build_choice
        building_unwanted
        ai_sell_obsolete_buildings
        ai_find_elvis_pos
        free_tiles
        make_elvises
        make_taxmen
        make_scientists
aihand.c        (place in aihand.h)     
        ai_calc_city_buy
aitech.c        (needs #include "aitech.h", place in aitech.h)
        get_government_tech
        get_wonder_tech
        ai_next_tech_goal_default
        adjust_tech_choice
        find_prerequisites
        ai_select_tech
        ai_select_tech_goal
aiunit.c        (place in aiunit.h)
        tile_is_accessible
        wonder_on_continent
        should_unit_change_homecity
        unit_belligerence_primitive
        stack_attack_value
        invasion_function
        reinforcements_value
        reinforcements_cost
        is_my_turn
        ai_military_findvictim
        ai_military_bodyguards
        ai_military_gothere
        find_nearest_friendly_port
        ai_manage_ferryboat