[Freeciv-Dev] Server crash during treaty (PR#17)

[chipr@xxxxxxxxxx]

Full_Name: Chip Richards
Version: 1.8.0 (and June 4th CVS)
OS: Linux 2.0.36, libc5.4.38
Submission from: (NULL) (206.0.90.5)


Server crashes with segfault when second player selects "Accept treaty" during
diplomacy meeting.  Failure reproducible with our save file using both the
released
1.8.0 server and with the CVS version as of 4 June 1999.  Tried several
variations
of the trade deal, but the crash always happens whenever tech advances are part
of
the deal on either side.  Exchanges involving only maps and/or gold work just
fine.

I did compile and link with debugging turned on, and run the server under gdb,
with
the following (example) results:

==============================================================================

starting game.
> 
> 
Program received signal SIGSEGV, Segmentation fault.
0x40031647 in _IO_vfprintf (s=0xbffff1d0, format=0x8088635 "%s acquire %s
(Treaty) from %s", ap=0xbffff460)
(gdb) bt
#0  0x40031647 in _IO_vfprintf (s=0xbffff1d0, format=0x8088635 "%s acquire %s
(Treaty) from %s", ap=0xbffff460)
#1  0x4003017e in _IO_vsprintf (string=0x8211dec "Machine Tools",
format=0xbffff484 "0\214\t\b\t", args=0x6d726547)
#2  0xbffff248 in ?? ()
Cannot access memory at address 0xfbad0001.
(gdb) q
The program is running.  Quit anyway (and kill it)? (y or n) y

===============================================================================

The actual treaty had no "Machine Tools" in it--neither player is that far along
yet.
These crashes always look similar: it's always _IO_vfprintf, then _IO_vsprintf,
then
garbage.  And the tech string in the vsprintf is always something not involved
in
the actual treaty--usually some advance neither of us has yet--but is a
different
technology name every time.

This is easily reproduced--write to me at "chipr@xxxxxxxxxx" and I'll send along
the
save file and instructions for re-creating the crash.  And if you can't recreate
it,
that means it's my system config, which would be nice to know also.