Complete.Org: Mailing Lists: Archives: freeciv-dev: June 1999:
Re: [Freeciv-Dev] Coding styles (not cranky mode)
Home

Re: [Freeciv-Dev] Coding styles (not cranky mode)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Mitch Davis <mjd@xxxxxxxxxx>
Cc: Daniel Sjolie <deepone@xxxxxxxxxx>, Freeciv List <freeciv-dev@xxxxxxxxxxx>
Subject: Re: [Freeciv-Dev] Coding styles (not cranky mode)
From: Jules Bean <jmlb2@xxxxxxxxxxxxxxxx>
Date: Thu, 03 Jun 1999 12:09:29 +0100

Mitch Davis wrote:
> 
> Jules Bean wrote:
> >
> > It is possible, I think, to set up cvs so that every time you checkout a
> > file it is indented using indent to your personal style, and whenever
> > you check it back in it is re-indented using the 'house style'.
> 
> This is in general a bad idea.  First, it assumes that every
> drop of code in CVS is house-style.

Which is not an unreasonable goal.  But I agree it might be tricky if
some other code got incorporated from another source.

> 
> Second (and more importantly), if you make changes, and send out
> a diff for people to test, that diff won't patch correctly against
> the code of others.

Well, I thought there was a clever solution to this.   I *think* that if
you set it up using wrappers, then it reindents to house style *before*
running a diff or a check-in.

Also note that there's an ignore-whitespace option to patch, which is a
good one for indentation issues.

Jules

-- 
/----------------+-------------------------------+---------------------\
|  Jelibean aka  | jules@xxxxxxxxxxxxxxx         |  6 Evelyn Rd        |
|  Jules aka     |                               |  Richmond, Surrey   |
|  Julian Bean   | jmlb2@xxxxxxxxxxxxxxxx        |  TW9 2TF *UK*       |
+----------------+-------------------------------+---------------------+
|  War doesn't demonstrate who's right... just who's left.             |
|  When privacy is outlawed... only the outlaws have privacy.          |
\----------------------------------------------------------------------/

[Prev in Thread] Current Thread [Next in Thread]