Re: [Freeciv-Dev] [patch] GUI-independant option code

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Sune Kirkeby <sune@xxxxxxxxxxxxx> wrote:

> Here is a patch that takes the (client) option list out of the
> gui-* directories, so new options only have to be added in
> one place. 

Thanks, looks good.

But some problems:
- Unified diffs (-u) are prefered, though -c is ok.
- menu.c now needs to include options.c, for proto for save_options()
- It looks like your patch includes code from the previous patch
  you posted (last_city_workers_color etc).  One fix/feature per patch
  please!
- The xaw client doesnt compile, with eg:
  client/gui-xaw/mapctrl.c:973: structure has no member named `workers_color'
  (looks like due to only part of the worker_colors patch being included).

Regards,
-- David