Re: [Freeciv-Dev] [patch] GUI-independant option code

[Sune Kirkeby <sune@xxxxxxxxxxxxx>]

On Sun, Apr 25, 1999 at 01:51:29PM +1000, David Pfitzner wrote:
> Sune Kirkeby <sune@xxxxxxxxxxxxx> wrote:
> 
> > Here is a patch that takes the (client) option list out of the
> > gui-* directories, so new options only have to be added in
> > one place. 
> 
> Thanks, looks good.
> 
> But some problems:
> - Unified diffs (-u) are prefered, though -c is ok.

Ok.  I'll try to remember that.

> - menu.c now needs to include options.c, for proto for save_options()

Done, client/gui-gtk/menu.c and client/gui-xaw/menu.c now include
options.h.

> - It looks like your patch includes code from the previous patch
>   you posted (last_city_workers_color etc).  One fix/feature per patch
>   please!

I have no idea how that ended up there, but it should be gone now.

> - The xaw client doesnt compile, with eg:
>   client/gui-xaw/mapctrl.c:973: structure has no member named `workers_color'
>   (looks like due to only part of the worker_colors patch being included).

I took a fresh CVS snapshot and applied the new patch, both GUIs compile
for me now.

Attached is the new patch, anything missing (or anything
superflous)  this time?

Sune Kirkeby

freeciv-shared_options.diff.gz
Description: application/gunzip