[Freeciv-Dev] Patch: AI: build fewer Harbors.

[Tony & <stuckey@xxxxxxxxxxxxxxxxx>]

        The AI really likes to build harbors.  For cities which have not
built an aqueduct yet, this is generally very wasteful.
        Cities under the size which requires an aqueduct can generally
feed themselves quite well.  If anyone has reasons why this is a poor fix,
please discuss them with me.

Index: ai/advdomestic.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/ai/advdomestic.c,v
retrieving revision 1.29
diff -u -r1.29 advdomestic.c
--- advdomestic.c       1998/10/25 05:24:46     1.29
+++ advdomestic.c       1998/12/07 22:31:59
@@ -294,7 +294,8 @@
   if (could_build_improvement(pcity, B_GRANARY) && !built_elsewhere(pcity,
B_PYRAMIDS))
     values[B_GRANARY] = grana * pcity->food_surplus;
   
-  if (could_build_improvement(pcity, B_HARBOUR))
+       /* Harbors are not generally useful to small cities. -AJS */
+  if (city_got_effect(pcity,B_AQUEDUCT) && could_build_improvement(pcity,
B_HARBOUR))
     values[B_HARBOUR] = food * ocean_workers(pcity) * hunger;
 
   if (could_build_improvement(pcity, B_HYDRO) && !built_elsewhere(pcity,
B_HOOVER))

-- 
Anthony J. Stuckey                              stuckey@xxxxxxxxxxxxxxxxx
"When I was young, the sky was filled with stars.
 I watched them burn out one by one."  -Warren Zevon