[freeciv-ai] Re: [Freeciv-Dev] (PR#9653) BUG: Maybe very easy, maybe not: savegame no more mach in positive years!

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=9653 >

Mateusz Stefek wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=9653 >
> 
> Game saved as jako civgame-1500.sav.gz
> 
>>==2682==
> 
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80ABD80: consider_settler_action (settlers.c:824)
> ==2682==    by 0x80AC2DE: evaluate_improvements (settlers.c:954)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==    by 0x80AD507: auto_settlers_player (settlers.c:1294)
> ==2682==
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80ABDCE: consider_settler_action (settlers.c:832)
> ==2682==    by 0x80AC2DE: evaluate_improvements (settlers.c:954)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==    by 0x80AD507: auto_settlers_player (settlers.c:1294)
> ==2682==
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80AA6D9: amortize (settlers.c:103)
> ==2682==    by 0x80ABDEA: consider_settler_action (settlers.c:834)
> ==2682==    by 0x80AC2DE: evaluate_improvements (settlers.c:954)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80AA6FB: amortize (settlers.c:104)
> ==2682==    by 0x80ABDEA: consider_settler_action (settlers.c:834)
> ==2682==    by 0x80AC2DE: evaluate_improvements (settlers.c:954)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80AA74D: amortize (settlers.c:111)
> ==2682==    by 0x80ABDEA: consider_settler_action (settlers.c:834)
> ==2682==    by 0x80AC2DE: evaluate_improvements (settlers.c:954)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80ABE0A: consider_settler_action (settlers.c:841)
> ==2682==    by 0x80AC2DE: evaluate_improvements (settlers.c:954)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==    by 0x80AD507: auto_settlers_player (settlers.c:1294)
> ==2682==
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80ABE25: consider_settler_action (settlers.c:841)
> ==2682==    by 0x80AC2DE: evaluate_improvements (settlers.c:954)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==    by 0x80AD507: auto_settlers_player (settlers.c:1294)
> ==2682==
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80ABE45: consider_settler_action (settlers.c:847)
> ==2682==    by 0x80AC2DE: evaluate_improvements (settlers.c:954)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==    by 0x80AD507: auto_settlers_player (settlers.c:1294)
> ==2682==
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80ABD80: consider_settler_action (settlers.c:824)
> ==2682==    by 0x80AC3C6: evaluate_improvements (settlers.c:970)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==    by 0x80AD507: auto_settlers_player (settlers.c:1294)
> ==2682==
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80ABE45: consider_settler_action (settlers.c:847)
> ==2682==    by 0x80AC3C6: evaluate_improvements (settlers.c:970)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==    by 0x80AD507: auto_settlers_player (settlers.c:1294)
> ==2682==
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80ABE4F: consider_settler_action (settlers.c:847)
> ==2682==    by 0x80AC3C6: evaluate_improvements (settlers.c:970)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==    by 0x80AD507: auto_settlers_player (settlers.c:1294)
> ==2682==
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80ABDCE: consider_settler_action (settlers.c:832)
> ==2682==    by 0x80AC463: evaluate_improvements (settlers.c:978)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==    by 0x80AD507: auto_settlers_player (settlers.c:1294)
> ==2682==
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80ABE45: consider_settler_action (settlers.c:847)
> ==2682==    by 0x80AC463: evaluate_improvements (settlers.c:978)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==    by 0x80AD507: auto_settlers_player (settlers.c:1294)
> ==2682==
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80ABE4F: consider_settler_action (settlers.c:847)
> ==2682==    by 0x80AC463: evaluate_improvements (settlers.c:978)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==    by 0x80AD507: auto_settlers_player (settlers.c:1294)
> ==2682==
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80ABE4F: consider_settler_action (settlers.c:847)
> ==2682==    by 0x80AC2DE: evaluate_improvements (settlers.c:954)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==    by 0x80AD507: auto_settlers_player (settlers.c:1294)
> ==2682==
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80AA6D9: amortize (settlers.c:103)
> ==2682==    by 0x80ABDEA: consider_settler_action (settlers.c:834)
> ==2682==    by 0x80AC463: evaluate_improvements (settlers.c:978)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80AA6FB: amortize (settlers.c:104)
> ==2682==    by 0x80ABDEA: consider_settler_action (settlers.c:834)
> ==2682==    by 0x80AC463: evaluate_improvements (settlers.c:978)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80AA74D: amortize (settlers.c:111)
> ==2682==    by 0x80ABDEA: consider_settler_action (settlers.c:834)
> ==2682==    by 0x80AC463: evaluate_improvements (settlers.c:978)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80ABE0A: consider_settler_action (settlers.c:841)
> ==2682==    by 0x80AC463: evaluate_improvements (settlers.c:978)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==    by 0x80AD507: auto_settlers_player (settlers.c:1294)
> ==2682==
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80ABE25: consider_settler_action (settlers.c:841)
> ==2682==    by 0x80AC463: evaluate_improvements (settlers.c:978)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==    by 0x80AD507: auto_settlers_player (settlers.c:1294)
> ==2682==
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80AC6FB: evaluate_improvements (settlers.c:1039)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==    by 0x80AD507: auto_settlers_player (settlers.c:1294)
> ==2682==    by 0x80ADD0D: auto_settlers_init (settlers.c:1437)
> ==2682==
> ==2682== Conditional jump or move depends on uninitialised value(s)
> ==2682==    at 0x80AC708: evaluate_improvements (settlers.c:1042)
> ==2682==    by 0x80ACB18: auto_settler_findwork (settlers.c:1109)
> ==2682==    by 0x80AD507: auto_settlers_player (settlers.c:1294)
> ==2682==    by 0x80ADD0D: auto_settlers_init (settlers.c:1437)

Oh duh.  This is a known bug (PR#9355).  I thought I'd made a patch but 
I don't see it there.

BTW my previous attachment was in error.  Here's the results of the 
comparison of savegames.

jason

orig new
civgame+0001.sav.gz : 
civgame+0020.sav.gz : 
civgame-0025.sav.gz : 
civgame+0040.sav.gz : 
civgame-0050.sav.gz : 
civgame+0060.sav.gz : 
civgame-0075.sav.gz : 
civgame+0080.sav.gz : 
civgame-0100.sav.gz : 
civgame+0100.sav.gz : 
civgame+0120.sav.gz : 
civgame-0125.sav.gz : 
civgame+0140.sav.gz : 
civgame-0150.sav.gz : 
civgame+0160.sav.gz : 
civgame-0175.sav.gz : 
civgame+0180.sav.gz : 
civgame-0200.sav.gz : 
civgame+0200.sav.gz : 
civgame+0220.sav.gz : 
civgame-0225.sav.gz : 
civgame+0240.sav.gz : 
civgame-0250.sav.gz : 
civgame+0260.sav.gz : 
civgame-0275.sav.gz : 
civgame+0280.sav.gz : 
civgame-0300.sav.gz : 
civgame+0300.sav.gz : 
civgame+0320.sav.gz : 
civgame-0325.sav.gz : 
civgame+0340.sav.gz : 
civgame-0350.sav.gz : 
civgame+0360.sav.gz : 
civgame-0375.sav.gz : 
civgame+0380.sav.gz : 
civgame-0400.sav.gz : 
civgame+0400.sav.gz : 
civgame+0420.sav.gz : 
civgame-0425.sav.gz : 
civgame+0440.sav.gz : 
civgame-0450.sav.gz : 
civgame+0460.sav.gz : 
civgame-0475.sav.gz : 
civgame+0480.sav.gz : 
civgame-0500.sav.gz : 
civgame+0500.sav.gz : 
civgame+0520.sav.gz : 
civgame-0525.sav.gz : 
civgame+0540.sav.gz : 
civgame-0550.sav.gz : 
civgame+0560.sav.gz : 
civgame-0575.sav.gz : 
civgame+0580.sav.gz : 
civgame-0600.sav.gz : 
civgame+0600.sav.gz : 
civgame+0620.sav.gz : 
civgame-0625.sav.gz : 
civgame+0640.sav.gz : 
civgame-0650.sav.gz : 
civgame+0660.sav.gz : 
civgame-0675.sav.gz : 
civgame+0680.sav.gz : 
civgame-0700.sav.gz : 
civgame+0700.sav.gz : 
civgame+0720.sav.gz : 
civgame-0725.sav.gz : 
civgame+0740.sav.gz : 
civgame-0750.sav.gz : 
civgame+0760.sav.gz : 
civgame-0775.sav.gz : 
civgame+0780.sav.gz : 
civgame-0800.sav.gz : 
civgame+0800.sav.gz : 
civgame+0820.sav.gz : 
civgame-0825.sav.gz : 
civgame+0840.sav.gz : 
civgame-0850.sav.gz : 
civgame+0860.sav.gz : 
civgame-0875.sav.gz : 
civgame+0880.sav.gz : 
civgame-0900.sav.gz : 
civgame+0900.sav.gz : 
civgame+0920.sav.gz : 
civgame-0925.sav.gz : 
civgame+0940.sav.gz : 
civgame-0950.sav.gz : 
civgame+0960.sav.gz : 
civgame-0975.sav.gz : 
civgame+0980.sav.gz : 
civgame-1000.sav.gz : 
civgame+1000.sav.gz : 
civgame+1010.sav.gz : 
civgame+1020.sav.gz : 
civgame+1030.sav.gz : 
civgame+1040.sav.gz : 
civgame-1050.sav.gz : 
civgame+1050.sav.gz : 
civgame+1060.sav.gz : 
civgame+1070.sav.gz : 
civgame+1080.sav.gz : 
civgame+1090.sav.gz : 
civgame-1100.sav.gz : 
civgame+1100.sav.gz : 
civgame+1110.sav.gz : 
civgame+1120.sav.gz : 
civgame+1130.sav.gz : 
civgame+1140.sav.gz : 
civgame-1150.sav.gz : 
civgame+1150.sav.gz : 
civgame+1160.sav.gz : 
civgame+1170.sav.gz : 
civgame+1180.sav.gz : 
civgame+1190.sav.gz : 
civgame-1200.sav.gz : 
civgame+1200.sav.gz : 
civgame+1210.sav.gz : 
civgame+1220.sav.gz : 
civgame+1230.sav.gz : 
civgame+1240.sav.gz : 
civgame-1250.sav.gz : 
civgame+1250.sav.gz : 
civgame+1260.sav.gz : 
civgame+1270.sav.gz : 
civgame+1280.sav.gz : 
civgame-1300.sav.gz : 
civgame-1350.sav.gz : 
civgame-1400.sav.gz : 
civgame-1450.sav.gz : identical
civgame-1500.sav.gz : identical
civgame-1550.sav.gz : identical
civgame-1600.sav.gz : identical
civgame-1650.sav.gz : identical
civgame-1700.sav.gz : identical
civgame-1750.sav.gz : identical
civgame-1800.sav.gz : identical
civgame-1850.sav.gz : identical
civgame-1900.sav.gz : identical
civgame-1950.sav.gz : identical
civgame-2000.sav.gz : identical
civgame-2050.sav.gz : identical
civgame-2100.sav.gz : identical
civgame-2150.sav.gz : identical
civgame-2200.sav.gz : identical
civgame-2250.sav.gz : identical
civgame-2300.sav.gz : identical
civgame-2350.sav.gz : identical
civgame-2400.sav.gz : identical
civgame-2450.sav.gz : identical
civgame-2500.sav.gz : identical
civgame-2550.sav.gz : identical
civgame-2600.sav.gz : identical
civgame-2650.sav.gz : identical
civgame-2700.sav.gz : identical
civgame-2750.sav.gz : identical
civgame-2800.sav.gz : identical
civgame-2850.sav.gz : identical
civgame-2900.sav.gz : identical
civgame-2950.sav.gz : identical
civgame-3000.sav.gz : identical
civgame-3050.sav.gz : identical
civgame-3100.sav.gz : identical
civgame-3150.sav.gz : identical
civgame-3200.sav.gz : identical
civgame-3250.sav.gz : identical
civgame-3300.sav.gz : identical
civgame-3350.sav.gz : identical
civgame-3400.sav.gz : identical
civgame-3450.sav.gz : identical
civgame-3500.sav.gz : identical
civgame-3550.sav.gz : identical
civgame-3600.sav.gz : identical
civgame-3650.sav.gz : identical
civgame-3700.sav.gz : identical
civgame-3750.sav.gz : identical
civgame-3800.sav.gz : identical
civgame-3850.sav.gz : identical
civgame-3900.sav.gz : identical
civgame-3950.sav.gz : identical