Complete.Org: Mailing Lists: Archives: offlineimap: September 2009:
Re: Last two patches
Home

Re: Last two patches

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Christoph Höger <choeger@xxxxxxxxxxxxxxx>
Cc: offlineimap@xxxxxxxxxxxx, Nicolas Sebrecht <nicolas.s-dev@xxxxxxxxxxx>
Subject: Re: Last two patches
From: Nicolas Sebrecht <nicolas.s-dev@xxxxxxxxxxx>
Date: Fri, 4 Sep 2009 15:50:48 +0200

On Fri, Sep 04, 2009 at 11:24:23AM +0200, Christoph Höger wrote:
> 
> Hi,

hi,

> Those two patches are essentially the dynamic plugin feature again plus
> a small HACKING file which documents how to use it (not too hard).
> Any other hacking related stuff could go in there too.

The patches are broken in two ways:
- the encoding is wrong;
- the line wrapping of mutt made the patches unusable.

Also (the most important FMPOV), the first patch do more than 1800
insertions and 1000 deletions. Nobody will review such a patch. Could
you please consider to split this patch?

-- 
Nicolas Sebrecht



[Prev in Thread] Current Thread [Next in Thread]