[Freeciv-Dev] Re: (PR#19510) [Bug] diplstate type plr1 -> plr2 different from plr2 -> plr1

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=19510 >

On Tue, 15 Aug 2006, Marko Lindqvist wrote:
> Per I. Mathisen wrote:
>>
>> On Mon, 14 Aug 2006, Marko Lindqvist wrote:
>>>  Problem is resolving love-love-hate in update_diplomatics(). Alliance
>>> is canceled in the middle of the player iteration. Iteration has already
>>> passed plr1->plr2 part, but plr2->plr1 follows. Turns_left is subtracted
>>> for one party, but not for the other.
>>
>> Good catch. Will this (untested) patch fix the problem? It also changes
>> the alliance breaking in LLH-situations, so that it does not arbitrarily
>> favour one party.
>>
>>   - Per
>>
>
>>                          "%s has run out. You are now at war with the %s."),
>>                          plr2->name, get_nation_name_plural(plr2->nation));
>>            state->type = DS_WAR;
>> +          state2->type = DS_WAR;
>> +          state2->turns_left = 0;
>
>  Doesn't this mean that plr2 never gets "You are now at war" -message
> above?

Yes, messages will have to go out to both players, too.

   - Per