Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2006:
[Freeciv-Dev] (PR#15260) Fwd: patch for ticket #15260
Home

[Freeciv-Dev] (PR#15260) Fwd: patch for ticket #15260

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Subject: [Freeciv-Dev] (PR#15260) Fwd: patch for ticket #15260
From: "Daniel Markstedt" <markstedt@xxxxxxxxx>
Date: Fri, 11 Aug 2006 18:08:14 -0700
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=15260 >

This transaction appears to have no content
Forwarding patch posted at freeciv-dev to RT.

--Daniel

---------- Forwarded message ----------
From: hamurAbi <hamurabi.dev@xxxxxxxxx>
Date: Aug 12, 2006 5:12 AM
Subject: [Freeciv-Dev] patch for ticket #15260
To: freeciv-dev@xxxxxxxxxxx

Hi folks,

Attached is a patch for the following problem. When the client is an
observer it didnt handle none of the acceleration keys.

> The 'Reports' menu in GTK2 client is erratic when observing.
>
> - Pressing the shortcut functions keys (F1-F3,F5-F9.F11) doesn't have
> any effect.

Thanks.
Forwarding patch posted at freeciv-dev to RT.

--Daniel

---------- Forwarded message ----------
From: hamurAbi < hamurabi.dev@xxxxxxxxx>
Date: Aug 12, 2006 5:12 AM
Subject: [Freeciv-Dev] patch for ticket #15260
To: freeciv-dev@xxxxxxxxxxx

Hi folks,

Attached is a patch for the following problem. When the client is an
observer it didnt handle none of the acceleration keys.

> The 'Reports' menu in GTK2 client is erratic when observing.
>
> - Pressing the shortcut functions keys (F1-F3,F5-F9.F11) doesn't have
> any effect.

Thanks.


Index: client/gui-gtk-2.0/gui_main.c
===================================================================
--- client/gui-gtk-2.0/gui_main.c       (revision 12251)
+++ client/gui-gtk-2.0/gui_main.c       (working copy)
@@ -463,7 +463,11 @@
     return TRUE;
   }
 
-  if (!client_is_observer()) { /* FIXME: is this check right? */
+  if (client_is_observer()) {
+    return FALSE;
+  }
+  else {
+/*  if (!client_is_observer()) { */   /* FIXME: is this check right? */
     if ((ev->state & GDK_SHIFT_MASK)) {
       switch (ev->keyval) {
        case GDK_Left:


[Prev in Thread] Current Thread [Next in Thread]