[Freeciv-Dev] Re: (PR#18605) [Bugfix] auto-return fixes

["Marko Lindqvist" <cazfi74@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=18605 >

Marko Lindqvist wrote:
> Marko Lindqvist wrote:
>> Jason Dorje Short wrote:
>>> Marko Lindqvist wrote:
>>>>   These fix several airplane auto-return problems
>>>>
>>>>   - Don't go for another refuel point if we are loaded to carrier.
>>>>   - If we are above free carrier: land
>>>>   - Once we reach free carrier: land
>>>>
>>
>>
>>   Still untested
> 
>   Doesn't work correctly for S2_1, and for TRUNK will work only after 
> #18574. If there is more planes flying above carrier than fit in, none 
> of them will be saved. This is because is_airunit_refuel_point() will 
> return FALSE for all of them.

  I think this patch should go in for TRUNK once #18574 is resolved.

  S2_1 is more complicated. This patch probably makes things only worse. 
In addition to above problem aircrafts sometimes attempt to auto-return 
to carriers that are already full. That is because 
count_units_with_extra_fuel parameter to airunit_carrier_capacity() is 
FALSE.



  - ML