[Freeciv-Dev] Re: (PR#18605) [Bugfix] auto-return fixes

["Marko Lindqvist" <cazfi74@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=18605 >

Marko Lindqvist wrote:
> 
> Jason Dorje Short wrote:
>> Marko Lindqvist wrote:
>>>   These fix several airplane auto-return problems
>>>
>>>   - Don't go for another refuel point if we are loaded to carrier.
>>>   - If we are above free carrier: land
>>>   - Once we reach free carrier: land
>>>
>>>   Untested
>> I'm pretty sure the use of "3" in this code should be replaced with 
>> SINGLE_MOVE.
> 
>   Done.
>   This is still not right in TRUNK, though. It should check for 
> UCF_TERRAIN_SPEED. I'll leave fixing that to later date.
> 
> 
>   Still untested

  Doesn't work correctly for S2_1, and for TRUNK will work only after 
#18574. If there is more planes flying above carrier than fit in, none 
of them will be saved. This is because is_airunit_refuel_point() will 
return FALSE for all of them.


  - ML