[Freeciv-Dev] Re: (PR#18573) Editor: change city name

["Jason Dorje Short" <jdorje@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=18573 >

Egor Vyscrebentsov wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=18573 >
> 
> Good daytime!
> 
> Attached patch allows to change city name in edit mode for editing
> connection.
> (I use editor as global observer and think that this is the best way
> for editing scenario.)
> No changes for gtk client made, so I think it still does not allow
> global observer to be good editor.
> Patch was tested in xaw client, with two another patches (enabling
> edit mode in xaw client and "None" palette in editor tools [which
> means map clicking works as in regular game].)

But you don't have to be in editor mode to change city names.  The only 
change is in editor mode you can edit *anyone's* city name, not just 
your own.  A new packet should not be needed.

> PS Why `svn diff` does not ignore *_gen.[ch]?
> (*_gen.[ch] diff attached as separate file in case somebody has no
> python.)

The _gen files have to be in SVN, otherwise people would need python to 
compile the code.

-jason