[Freeciv-Dev] Re: (PR#18113) caravan with no homecity crashes server

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=18113 >

On Mon, 26 Jun 2006, Mike Kaufman wrote:
>> If one load a .sav file which contain caravan with no homecity, server
>> will crash next turn. Problem is that aicore caravan code assume that
>> caravan always has homecity, and server does not check for this when
>> load a game. Also, it seems to me that editor allows to create caravan
>> without homecity.
>> I'm not sure who own this bug: server, editor, or both.
>
> I would say this is a editor bug primarily, but annoying enough to fix via
> the fixing the editor that I would say a server bug.

I think the best short-term solution is to allow changing homecity of 
caravans in editor mode, so that scenario editing can add valid caravans, 
and delete with LOG_ERROR any caravans that do not have homecity on 
savegame loading. That way the scenario editing user will notice what is 
amiss and can fix it easily.

   - Per