[Freeciv-Dev] (PR#15649) SDL-client: corrupted save - hangs

["Christian Prochaska" <cp.ml.freeciv.dev@xxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=15649 >

> [Martin.Gerdes@xxxxxxxxxxxxx - Mo 20. Feb 2006, 17:05:54]:
> 
> Hi!
> 
> I have gotten a corrupted save, although I don't have any idea how it
>    happened.
> The city "This" just grew to size two, and because of that, I wanted
>    to reassign one of its workers to a different tile. But as soon as
>    I click on the wood+river tile I don't want to have worked, the
>    SDL-client hangs. I tried restarting client and server, but the
>    behavior stays.
> 
> The save and a picture are attached (as tar.gz archive).
> 
> Played with freeciv CVS-HEAD snapshot from 31.1.06, SDL-client
>    (patched), and deluxe theme.
> 

Here's a patch. It was a bug in the client.

Index: client/gui-sdl/citydlg.c
===================================================================
--- client/gui-sdl/citydlg.c    (Revision 11623)
+++ client/gui-sdl/citydlg.c    (Arbeitskopie)
@@ -3357,7 +3357,7 @@
     i = 0;
     
     pBuf = pIcons->pBIG_Shield;
-    while (count) {
+    while (count > 0) {
       SDL_BlitSurface(pBuf, NULL, pWindow->dst, &dest);
       dest.x += pBuf->w;
       count--;