[Freeciv-Dev] (PR#15589) SDL-client: Not all units shown in garrison panel

["Christian Prochaska" <cp.ml.freeciv.dev@xxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=15589 >

> [Martin.Gerdes@xxxxxxxxxxxxx - Fr 17. Feb 2006, 02:02:15]:
> 
> Hello!
> 
> If I have more than 3 units stationed inside a city, not all of them
>    are shown in the city garrison panel. I have attached a save game.
>    Look into the cities Djeuka and Yuni.
> 
> This is bad, because it makes it basically impossible to select the
>    units which aren't shown, without moving everything else out of the
>    city.
> 
> Played with freeciv CVS-HEAD snapshot from 31.1.06, SDL-client, and
>    deluxe theme. SDL-client patched with the border, unitlist, and
>    revolution patches (popup patch didn't apply for me - will get it
>    with the next snapshot...)
> 
> Kind regards,
> 
> Icekiss
> 
> 

Hm, I couldn't reproduce this. In my test all units were shown (though
the unit background should be transparent instead of black, patch
attached).

Index: client/gui-sdl/citydlg.c
===================================================================
--- client/gui-sdl/citydlg.c    (Revision 11600)
+++ client/gui-sdl/citydlg.c    (Arbeitskopie)
@@ -728,10 +728,8 @@
       sz_strlcat(cBuf, "\n");
       sz_strlcat(cBuf, get_nearest_city_text(pNear_City, pCity_near_dist));
       pSurf = adj_surf(create_unit_surface(pUnit, 1));
-      SDL_SetColorKey(pSurf, SDL_SRCCOLORKEY, 0);
     } else {
       pSurf = adj_surf(create_unit_surface(pUnit, 0));
-      SDL_SetColorKey(pSurf, SDL_SRCCOLORKEY, 0);      
     }
         
     pStr = create_str16_from_char(cBuf, adj_font(10));