[Freeciv-Dev] Re: (PR#15098) Re: civserver crash in calc_unit_ordering

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=15098 >

Mike Kaufman wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=15098 >
> 
> save_game is getting called here: in sniff_packets()
> 
>     /* end server if no players for 'srvarg.quitidle' seconds */
>     if (srvarg.quitidle != 0 && server_state != PRE_GAME_STATE) {
>       static time_t last_noplayers;
>       if(conn_list_size(&game.est_connections) == 0) {
>         if (last_noplayers != 0) {
>           if (time(NULL)>last_noplayers + srvarg.quitidle) {
>             if (srvarg.exit_on_end) {
>               save_game_auto();
>             }
> 
> because the game is not in PRE_GAME_STATE at the time. So the bug has to be
> that the server is in SELECT_RACES_STATE and have no players at the same
> time. Did anyone much with that code recently?

I committed a patch to this exact same piece of code (the quitidle 
patch), but only to the development version.

-jason