[Freeciv-Dev] Re: (PR#15033) clients crashing when trying to connect to network game

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=15033 >

On Sat, Dec 31, 2005 at 11:07:06AM -0800, Jason Short wrote:
> 
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=15033 >
> 
> This bug is in the metaserver.  It is legal for player names to have 
> quotation marks in them, but the megtaserver does not correctly escape 
> these quotes.

ok, I've modified the metaserver to add slashes to names and such, I don't
have access to a client at the moment to try it out, but the slashes show
up when given a name with quotes. Of course this screws things up since now
you also see things like "Joe\'s" on the metaserver which of course we
don't want.

The solution should be:
0. a better solution for metaserver: sanitize names and such by
   removing quotes since that's where mysql gets huffy.
1. illegal for player names to have quotes. apostrophes ok.
2. create_ai_player() should use get_tokens() so you can create players
like "Joe Bob" except without the quotes.

-mike