[Freeciv-Dev] Re: (PR#14305) Client crash on /endgame

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=14305 >

Mike Kaufman wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=14305 >
> 
> a proposed fix for the fix.

Background:

<kauf> apply your patch
...
<kauf> well, your patch is wrong
<kauf> it'll certainly trip the assert(0) at the end of the function
...
<kauf> you make the assumption that nothing in end_turn() ends the game
...
<jdorje> but your patch also makes that assumption
<jdorje> because if something in end_turn ends the game, the second 
break would be hit and the thaw wouldn't be done
...
<kauf> I think end_phase can safely be done even if the game is already over

so I agree this new fix is correct.

-jason