[Freeciv-Dev] Re: (PR#14764) Patch to get SDL client compile and start on AmigaOS

["Vasco Alexandre da Silva Costa" <vasco.costa@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=14764 >

On 12/4/05, Nicolas A. Mendoza <mendoza@xxxxxxxxxxx> wrote:
>
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=14764 >

Hello Nicolas,

> - renamed "help" enum's members to HELP_#? (to avoid clash with TEXT)

Seems fine.

> - Added an Amiga entry in configure.ac to allow run as root (only one user
> in AmigaOS currently)

Looks fine.

> - utility/mem.c relies on that malloc(0) returns a pointer with 0 or as
> little as possible mem allocated. This is implementation specific
> according to ANSI C, and with the c library clib2 on AmigaOS, it returns
> an as correct NULL pointer isntead. Quick #ifdef hack that always
> allocates at least one byte. (since the poitner is always going to be
> freed anyway)

Ah, I would rather make it always like this, than adding an OS specific #ifdef.
You could just do:
  if (size == 0) {
    size = 1;
  }

-Vasco Alexandre da Silva Costa