[Freeciv-Dev] (PR#14639) Patch for SDL client

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=14639 >

OK, now gui-sdl compiles.  The next hurdle to tackle is the graphics
problem.

The so-called "DELUX" tileset will never be included in freeciv, or
hosted on freeciv.org, because it contains non-free graphics.  If it
shows up on rt.freeciv.org or in the mailing lists we need to delete it
from here as well.

The "theme" graphics themselves are of uncertain copyright.  Unless we
can find an exact author for each graphic, I doubt we are safe in
including them.  The delux tileset itself shows that Rafal was very
sloppy with following image ownership, and this uncertainty extends over
to all the other graphics he provided.  So, all of these graphics need
to either have their exact origin tracked down (some come from LGeneral
I believe; Lincity-ng and other games also use some similar icons) or
remade (preferably using SVG for the icons and layout graphics to make
them scalable).

Aside from this we have a design issue.  I do not generally agree with
GUIs adding "theme" graphics to the tileset: doing so means tilesets
will not have consistent behavior across GUIs and it makes tileset
writing a lot harder.  Instead I think the "theme" mechanism should be
used and these graphics should go into a gui-sdl theme.

-jason