[Freeciv-Dev] Re: (PR#14652) Patch proposal: resources cleanup

["Vasco Alexandre da Silva Costa" <vasco.costa@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=14652 >

On 11/21/05, Jerome Plut <Jerome.Plut@xxxxxx> wrote:
>
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=14652 >
>
> If you look closer into the code, you will see that the majority of
> the volume of the patch is due to a cousin of
> s/special/modification/g. The actual code changes are rather few.

Hello Jérôme,

Perhaps we could apply a rename patch first.

> > Next, I agree "specials" is a bad name.  "Resources" is a bit better,
> > though perhaps not perfect in the context of my intended design (see
> > below).  "Infrastucture" and "modifications" are also possible terms
> > ("infrastrucutre" is used in the code in a few places).
>
> I thought about this, and did _definitely not_ want nuclear fallout to
> be classified as infrastructure... :-) Besides, get_infrastructure_set
> would have been very self-confusing code.

Here are some more names: Trait, Aspect, Property, Attribute, etc.

Although I do prefer Resources.
I also seem to remember Civilization III and Master of Magic use that name.

> Why not provide a savegame translator (in the distribution, but
> separate from civserver)? This is a mass of program that is mostly
> encumbering in the civserver, considering that it only has to be used
> in some specific cases. (I agree that this would however shift a bit
> more weight on the user, which is a bad thing. Or maybe you could have
> savegame.c autorun this converter).

Because it would means there would be two sets of savedgame parser code
and noone would maintain it?

All the best,
-Vasco Alexandre da Silva Costa