[Freeciv-Dev] (PR#14389) client goto ignores invalid moves caused by transported units

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=14389 >

> [mstefek - Thu Oct 20 07:16:51 2005]:
> 
> Dnia 2005-10-20 04:38:56, Jason Short napisał(a):
> > 
> > <URL: http://bugs.freeciv.org/Ticket/Display.html?id=14389 >
> > 
> > I am allied with mongols and chinese.  There is a chinese unit stuck
> > on
> > my frigate.  I press "shift-G" to return to a city to dump him.  This
> > tries to take me to a mongol city.  But since mongols and chinese are
> > NOT allied, I'm not allowed to move into the city.
> > 
> > The same behavior is exhibited on regular client goto (g).
> 
> So the goto has to check if a unit an its cargo is allied with the city.

Clearly.  However this is not easy because (drum roll...) the pf_param
doesn't have a unit pointer/id and so doesn't know what units are
transported.

Possible solution: prevent allied transporting (team transporting should
still be allowed).

Incidentally, this is probably a much bigger problem for the AI.

-jason