[Freeciv-Dev] (PR#13595) pubserver crash: MAP_NCONT is overrun

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13595 >

> [jdorje - Wed Aug 03 00:40:50 2005]:
> 
> The attached RC file creates the crash with CVS S2_0 from "Wed Aug  3 
> 00:39:38 UTC 2005" (probably with 2.0.4 also).  Note the unusual 
> settings - particularly tinyisles.

Oddly, the continents are renumbered three times during mapgen:

2: 59 continents; 6 oceans
2: 619 continents; 7 oceans
2: 86 continents; 7 oceans

the first two are obviously discarded maps...but cause a crash anyway.

Solution: assign_continent_numbers should return FALSE if it fails.

-jason