[Freeciv-Dev] (PR#13478) don't dereference T_UNKNOWN in the client goto code

["Mateusz Stefek" <mstefek@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13478 >

> [jdorje - Sat Jul 16 03:39:02 2005]:
> 
> All known bugs with T_UNKNOWN dereferences are now fixed.  Surely there
> are some more bugs out there.  Send any backtraces for crashes; a
> backtrace is probably enough to find the problem.
> 
Here you are, looks like I've found new city in a hut:

#0  0x080fa1f8 in is_terrain_flag_near_tile (ptile=0xb6b4497c,
    flag=TER_OCEANIC) at terrain.c:378
        adjc_tile = (struct tile *) 0xb6b4302c
        _y_itr = 38
        _is_border = false
        _center_tile = (const struct tile *) 0xb6b4497c
        _dir_index = 0
        _x_itr = 27
        ADJC_ITERATE_dir_itr = DIR8_NORTHWEST
#1  0x0809f655 in can_build_unit_direct (pcity=0x8d84658, id=3) at
city.c:472
        impr_req = 200
#2  0x0809f695 in can_build_unit (pcity=0x8d84658, id=3) at city.c:484
No locals.
#3  0x080ff8b2 in best_role_unit (pcity=0x8d84658, role=64) at
unittype.c:592
        u = 3
        j = 0
#4  0x080a1f1f in create_city_virtual (pplayer=0x81a7374, ptile=0xb6b4497c,
    name=0x8cfb398 "Manila") at city.c:2400
        u = 13
        i = 200
        pcity = (struct city *) 0x8d84658
#5  0x0807607d in handle_city_short_info (packet=0x8cfb388) at
packhand.c:643
        pcity = (struct city *) 0x0
        city_is_new = true
        city_has_changed_owner = false
        update_descriptions = false
#6  0x0807b740 in client_handle_packet (type=PACKET_CITY_SHORT_INFO,
    packet=0x8cfb388) at packhand_gen.c:113
No locals.
#7  0x08059a42 in handle_packet_input (packet=0x8cfb388, type=22)
    at civclient.c:390
No locals.
#8  0x0805e2dd in input_from_server (fd=7) at clinet.c:342
        result = true
        packet = (void *) 0x8cfb388
        type = PACKET_CITY_SHORT_INFO
#9  0x08126422 in get_net_input (data=0x0, fid=7, condition=GDK_INPUT_READ)
    at gui_main.c:1569

Only the client crashes.
--
mateusz