[Freeciv-Dev] Re: (PR#13461) Improve sanity of logging
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
|
Subject: |
[Freeciv-Dev] Re: (PR#13461) Improve sanity of logging |
|
From: |
"Per I. Mathisen" <per@xxxxxxxxxxx> |
|
Date: |
Tue, 12 Jul 2005 13:49:07 -0700 |
|
Reply-to: |
bugs@xxxxxxxxxxx |
<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13461 >
On Tue, 12 Jul 2005, Jason Short wrote:
> > Ehm, but that is surely outside the scope of my patch? If there is memory
> > leak in the calling code, then that is a separate problem, and this patch
> > changes nothing in that regard?
>
> No because currently the calling code has to do a strdup of the string
> before passing it in to the log function, whereas under your path the
> calling code isn't supposedto do a strdup.
Ah. Then this is not a problem, I think. Some memory is allocated in
civserver.c from get_option(), but since this is kept referenced, it is
not leaked, even though it would no longer be used.
- Per
|
|
