Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2005:
[Freeciv-Dev] (PR#13384) [Patch] unit_class_transporter_capacity()
Home

[Freeciv-Dev] (PR#13384) [Patch] unit_class_transporter_capacity()

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: marko.lindqvist@xxxxxxxxxxx
Subject: [Freeciv-Dev] (PR#13384) [Patch] unit_class_transporter_capacity()
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 4 Jul 2005 11:29:11 -0700
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13384 >

> [cazfi - Thu Jun 30 15:18:49 2005]:
> 
> 
>   This patch replaces ground_unit_transporter_capacity() and 
> is_ground_units_transport() with more generic 
> unit_class_transporter_capacity() and can_unit_type_transport().

Nice change.  The poorness of this particular part of the interface has
always bugged me, but I never fixed it after I realized it wouldn't be
trivial to change.

>   Biggest change is that ground_unit_transporter_capacity() used to 
> subtract even not transported units from capacity, for instance when 
> transporter is in a city, but unit_class_transporter_capacity() returns 
> actual free space in transporters. As a side effect #11064 is solved to 
> the extend that it does not cause real problems (allied transporter 
> filled with allys allies is not considered empty)

I think this is just a remnant from before was had strict transporting.

-jason




[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] (PR#13384) [Patch] unit_class_transporter_capacity(), Jason Short <=