Complete.Org: Mailing Lists: Archives: freeciv-dev: June 2005:
[Freeciv-Dev] Re: (PR#13366) get_invention and A_FUTURE
Home

[Freeciv-Dev] Re: (PR#13366) get_invention and A_FUTURE

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: mstefek@xxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#13366) get_invention and A_FUTURE
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 28 Jun 2005 14:50:04 -0700
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13366 >

Mateusz Stefek wrote:

> -  assert(tech >= 0 || tech < game.control.num_tech_types);
> +  assert(tech == A_FUTURE ||
> +         (tech >= 0 && tech < game.control.num_tech_types));

This will cause some more crashes I imagine.  But it's better to find
the bugs now.  Any bugs we do find here may need to be backported to 2.0.

Also, the style above is wrong.  The operator (||) is supposed to be at
the start of the new line.

-jason





[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] Re: (PR#13366) get_invention and A_FUTURE, Jason Short <=