[Freeciv-Dev] Re: (PR#13360) Choose random tech and future tech
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13360 >
Mateusz Stefek wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=13360 >
>
>>[jdorje - Tue Jun 28 17:31:07 2005]:
>>
>>Mateusz Stefek wrote:
>>
>>><URL: http://bugs.freeciv.org/Ticket/Display.html?id=13360 >
>>>
>>>choose_random_tech can't set A_FUTURE and this leads to many bugs.
>>>For example: http://pubserver.freeciv.org/games/443089
>>>
>>>Patch attached.
>>
>>I don't understand. Of course choose_random_tech can set A_FUTURE, if
>>it's reachable. If it's not reachable we don't want to choose it anyway.
>>
>>You can see this in action in any late game. Once all techs are found
>>and there's no goal, choose_random_tech chooses a new tech for you each
>>turn. And it always chooses A_FUTURE.
>>
>>-jason
>>
>
> choose_random_tech() uses choose_tech().
Not in 2.0 it doesn't.
> choose_tech ignores A_FUTURE as it's argument.
Only if it's unreachable. This looks correct.
> Note that my patch modifies choose_tech().
Yah.
> I don't know if get_invention() can be called on A_FUTURE
> at least in CVS it returns TECH_UNKNOWN
Really? Seems like that's the bug.
Note that it *should* return TECH_UNKNOWN if all techs haven't been
discovered.
-jason
|
|