[Freeciv-Dev] (PR#13342) pubserver 2.0 crash in found_new_tech

["Mateusz Stefek" <mstefek@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13342 >

> [jdorje - Mon Jun 27 19:34:06 2005]:
> 
> I reverted the 13198 patch in S2_0.
> 
> This should (once the pubservers rebuild) prevent future crashes of this
> type.  However it means the (relatively minor) 13198 bug is back.
> 
> I'm not sure if the 13198 patch should be reverted in the dev branch
> also, or if we should just look for a better fix.
> 
The problems with those crashes were that after choose_random_tech()
player.research.researching was still A_UNSET.
As I can see this is the main reason to call that function in S2_0

I think you should commit the 13198 back into S2_0 and change
choose_random_tech() to be similar to it's HEAD version:

choose_random_tech()
{
  do {
  choose(random_tech)
  } while(player researching A_UNSET)
}

--
mateusz