[Freeciv-Dev] Re: (PR#13343) pubserver 2.0 crash in handle_nation_select_req

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13343 >

Jason Short wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=13343 >
> 
> 
>   if (!is_ascii_name(name)
>       && find_conn_by_user(pplayer->username)->access_level != ALLOW_HACK) {
> 
> I assume find_conn_by_user is returning NULL.  This would happen I think
> if the player was an observer.  I haven't checked any of this however.

However the player is not an observer.

Player 2 is the offending one.  AI control is off.  The username is
unassigned.  pplayer->was_created is false.  pplayer->is_observer is
false.  pplayer->name is "samur".

There is one connection.  This connection has username samur.  The
connection is not an observer.

So the bug in the above code (that crashes) is obvious but the player is
not in a "sane" state and I don't know why.

-jason