Complete.Org: Mailing Lists: Archives: freeciv-dev: June 2005:
[Freeciv-Dev] Re: (PR#13136) extending the unit class
Home

[Freeciv-Dev] Re: (PR#13136) extending the unit class

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#13136) extending the unit class
From: "Marko Lindqvist" <marko.lindqvist@xxxxxxxxxxx>
Date: Sat, 25 Jun 2005 08:16:59 -0700
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13136 >

Jason Dorje Short wrote:
> 
> In unittype.h there is a unit class, along with some accessor code for it.
> 
> This enum is about 5 years old.  However nobody uses it (except some AI
> code which is likely buggy).  I would like to fix it up as a superset of
> the move-class concept.  Ultimately the move-class may be replaced and
> only the unit-class will remain.  In the meantime there is a fair bit of
> confusion because class names overlap ("Air" is a unit-class and a
> move-class name).
> 
> Ultimately the unit-classes should be defined in the ruleset.

  Attached patch removes move_type from unit.ruleset and has class 
instead. Internally move_type enumeration is still used for now, 
determined from class when rulesets are loaded.


  - ML

Attachment: movetype2class.diff.gz
Description: GNU Zip compressed data


[Prev in Thread] Current Thread [Next in Thread]