[Freeciv-Dev] Re: (PR#13308) global_advances array

["Peter Schaefer" <peter.schaefer@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13308 >

Wouldn't it better to convert global_advances array to bool only when
it is sent to the client, and keep using it in tech_parasite_effect?
Not that it matters that much :-)

wouldn't it be even better - in respect to the spying on tech effect -
to compute it on the fly for each player, and to only count the techs
of nations the player has met, including himself :-)

On 6/22/05, Mateusz Stefek <mstefek@xxxxxxxxx> wrote:
> 
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=13308 >
> 
> Currently it holds information about how many players has researched a tech.
> There are two problems with it:
> - It is sent to the client
> The client needs only boolean value: if there is a civilization knowing
> a tech. More info allows only cheating
> 
> - It is/will be hard to update with team research
> 
> The attached patch changes the type of the array to bool.
> The only place where we really needed integer value was in
> do_tech_parasite_effect(). I changed this function to count players each
> time it is called.
> 
> --
> mateusz
> 
> 
>