[Freeciv-Dev] (PR#13221) "make dist" fails on built sources

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13221 >

Reinier Post wrote:

> It turns out that "make dist" is failing:
> 
> make[2]: Entering directory `/home/freeciv/freeciv/server/scripting'
> ../../dependencies/tolua/tolua -n api -o ./api_gen.c -H ./api_gen.h ./api.pkg
> make[2]: ../../dependencies/tolua/tolua: Command not found
> make[2]: *** [api_gen.c] Error 127
> make[2]: Leaving directory `/home/freeciv/freeciv/server/scripting'
> make[1]: *** [distdir] Error 1
> make[1]: Leaving directory `/home/freeciv/freeciv/server'
> make: *** [distdir] Error 1
> + error 'Make dist failed.'
> + log 'Make dist failed.'
> ++ date +%X
> + echo 00:06:47 'Make dist failed.'
> + exit 1
> 
> Either "make dist" shouldn't attempt to run any Lua scripts or it
> should have a dependency that builds tolua first.   I would tend
> to the first, but I'm not sure.  I can't find how the "dist" target
> in the Makefile is generated so some help would be much appreciated.
> 

The basic problem is the built sources are included in the foo_SOURCES
list which means they are to be distributed.  To distribute them means
building them, but they can't be built because tolua isn't built for a
"make dist".

I believe this patch should fix it.  See

http://lists.gnu.org/archive/html/automake/2001-04/msg00094.html
http://sources.redhat.com/automake/automake.html#Dist

However I'm not sure if the nodist_foo_SOURCES requires a particular
version of automake.

-jason

? freeciv-2.0.99-devel
Index: server/scripting/Makefile.am
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/scripting/Makefile.am,v
retrieving revision 1.4
diff -u -r1.4 Makefile.am
--- server/scripting/Makefile.am        10 May 2005 16:58:53 -0000      1.4
+++ server/scripting/Makefile.am        6 Jun 2005 23:13:26 -0000
@@ -8,13 +8,11 @@
        -I$(top_srcdir)/dependencies/lua/include \
        -I$(top_srcdir)/dependencies/tolua
 
-libscripting_a_SOURCES = \
+dist_libscripting_a_SOURCES = \
                api_actions.c   \
                api_actions.h   \
                api_find.c      \
                api_find.h      \
-               api_gen.c       \
-               api_gen.h       \
                api_intl.c      \
                api_intl.h      \
                api_methods.c   \
@@ -29,6 +27,10 @@
                script_signal.c \
                script_signal.h
 
+nodist_libscripting_a_SOURCES =        \
+               api_gen.c       \
+               api_gen.h
+
 BUILT_SOURCES = $(srcdir)/api_gen.c $(srcdir)/api_gen.h
 CLEANFILES = $(srcdir)/api_gen.c $(srcdir)/api_gen.h