[Freeciv-Dev] (PR#13220) Science tab color should indicate urgency

["Daniel Speyer" <dspeyer@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13220 >

I like the new tab interface for reports in the gtk2 client, but one
thing bugs me: the science report turns red every time there is an
advance.  It seems to me that red should indicate something that
requires my immidiate attention, which the discovery of an
intermidiate tech on the way to my goal does not.

Here is a patch to turn the tab red only if you have no goal or have
completed your goal (ie scientists don't know what to researtch next),
and turns it blue if you've just made a stop on the way.  I've tested
it in every case I could think of and it worked fine.

--- old-repodlgs.c      2005-06-05 09:35:03.000000000 -0400
+++ repodlgs.c  2005-06-05 09:37:09.000000000 -0400
@@ -145,8 +145,11 @@
     
     create_science_dialog(make_modal);
   }
-
-  gui_dialog_present(science_dialog_shell);
+  if (game.player_ptr->ai.tech_goal == A_UNSET) {
+    gui_dialog_present(science_dialog_shell);
+  }else{
+    gui_dialog_alert(science_dialog_shell);
+  }
 }